Update Data docs based on feedback #3733
Conversation
| @@ -12,10 +12,10 @@ import { | |||
| ToolbarExample, | |||
| } from '../../examples/components/'; | |||
|
|
|||
| Data is the wrapper component and orchestrator for a set of subcomponents. Because this set of components work together to create the entirety of the experience, we like to refer to them as "Data and friends". | |||
| Because this set of components work together to create the entirety of the experience, we like to refer to them as "Data and friends". | |||
There was a problem hiding this comment.
I feel like Im asking myself "what set of components" while reading this
There was a problem hiding this comment.
Should I maybe keep the first sentence, but just say "Data is the orchestrator for a set of subcomponents." (just cut out the "wrapper" bit)
There was a problem hiding this comment.
yeah.. I think just the beginning is what threw me off..
maybe yeah starting with "Data is the orchestrator for a set of subcomponents. These components work together to create the entirety of the experience, we like to refer to them as "Data and friends"."
There was a problem hiding this comment.
^ I agree the beginning also threw me off, felt like it needed a little more of an intro
Hmm yes I think we should look into this separately on Grommet. |
Deploy Preview
What does this PR do?
Some light touch follow ons based on feedback to:
Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?