-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create how to compose a toolbar guide #3724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, otherwise looks good
aries-site/src/pages/learn/how-to-add-additional-controls-to-a-toolbar.mdx
Outdated
Show resolved
Hide resolved
…-toolbar.mdx Co-authored-by: Jessica Filben <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
aries-site/src/pages/learn/how-to-add-additional-controls-to-a-toolbar.mdx
Outdated
Show resolved
Hide resolved
aries-site/src/pages/learn/how-to-add-additional-controls-to-a-toolbar.mdx
Outdated
Show resolved
Hide resolved
aries-site/src/pages/learn/how-to-add-additional-controls-to-a-toolbar.mdx
Outdated
Show resolved
Hide resolved
aries-site/src/pages/learn/how-to-add-additional-controls-to-a-toolbar.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now! Thanks
looks like we have this warning |
Whoops, I'll take a look and see what to resolve. |
think we just need to update our node version |
Deploy Preview
What does this PR do?
Create how-to guide for how to add additional controls to a toolbar by composing your own.
To do:
Closes #3712
Where should the reviewer start?
aries-site/src/pages/learn/how-to-add-additional-controls-to-a-toolbar.mdx
What testing has been done on this PR?
Locally.
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?