Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create how to compose a toolbar guide #3724

Merged
merged 5 commits into from
Feb 17, 2024
Merged

Create how to compose a toolbar guide #3724

merged 5 commits into from
Feb 17, 2024

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Feb 14, 2024

Deploy Preview

What does this PR do?

Create how-to guide for how to add additional controls to a toolbar by composing your own.

To do:

  • Add code snippets/inline example at the end of final product. NOTE: Once pagination work is merged in grommet, we can remove the components added for this example.

Closes #3712

Where should the reviewer start?

aries-site/src/pages/learn/how-to-add-additional-controls-to-a-toolbar.mdx

What testing has been done on this PR?

Locally.

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@taysea taysea requested review from britt6612 and jcfilben February 14, 2024 01:06
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise looks good

Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@taysea taysea requested a review from britt6612 February 16, 2024 00:22
Copy link
Collaborator

@britt6612 britt6612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! Thanks

@britt6612
Copy link
Collaborator

looks like we have this warning
error [email protected]: The engine "node" is incompatible with this module. Expected version ">= 18". Got "16.20.2" error Found incompatible module.

@taysea
Copy link
Collaborator Author

taysea commented Feb 16, 2024

looks like we have this warning error [email protected]: The engine "node" is incompatible with this module. Expected version ">= 18". Got "16.20.2" error Found incompatible module.

Whoops, I'll take a look and see what to resolve.

@britt6612
Copy link
Collaborator

looks like we have this warning error [email protected]: The engine "node" is incompatible with this module. Expected version ">= 18". Got "16.20.2" error Found incompatible module.

Whoops, I'll take a look and see what to resolve.

think we just need to update our node version

@taysea taysea merged commit 0393f6d into master Feb 17, 2024
7 of 9 checks passed
@taysea taysea deleted the composed-toolbar-guide branch February 17, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create how-to guide for "composed toolbar"
3 participants