Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sentence case wizard cancelation buttons #3721

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Sentence case wizard cancelation buttons #3721

merged 1 commit into from
Feb 13, 2024

Conversation

halocline
Copy link
Collaborator

@halocline halocline commented Feb 13, 2024 •
edited
Loading

Deploy Preview

What does this PR do?

Update buttons in Wizard cancellation to follow sentence case guidelines.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@halocline halocline merged commit 6222cc4 into master Feb 13, 2024
7 of 9 checks passed
@halocline halocline deleted the wizard-sentence-case branch February 13, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@britt6612 britt6612 britt6612 approved these changes

@jcfilben jcfilben Awaiting requested review from jcfilben

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halocline @britt6612