Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update how to guide for toolbar #3715

Merged
merged 3 commits into from
Feb 12, 2024
Merged

update how to guide for toolbar #3715

merged 3 commits into from
Feb 12, 2024

Conversation

britt6612
Copy link
Collaborator

@britt6612 britt6612 commented Feb 9, 2024

Deploy Preview

  • @taysea if you can update your codesandbox to be with the latest grommet

What does this PR do?

This PR updates what we have for adding toolbar

Where should the reviewer start?

how-to-add-search-and-filter-to-datatable-with-data.mdx

What testing has been done on this PR?

locally
In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

locally

Any background context you want to provide?

The toolbar prop does not by default open up in a Drop it now opens in a Layer.

What are the relevant issues?

closes #3711

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

no

Is this change backwards compatible or is it a breaking change?

backwards compatible

@britt6612 britt6612 requested review from taysea and jcfilben February 9, 2024 20:59
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should change this text
Now, when the filters menu is opened, the filters will look like this:
to this:
Now, when the filters layer is opened, the filters will look like this:

@britt6612
Copy link
Collaborator Author

Wondering if we should change this text Now, when the filters menu is opened, the filters will look like this: to this: Now, when the filters layer is opened, the filters will look like this:

yes agree

@britt6612 britt6612 requested a review from jcfilben February 12, 2024 17:11
Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@taysea taysea merged commit e5eb9a1 into master Feb 12, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit simple "toolbar" guide updating if necessary
3 participants