Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search guidance suggestions #3671

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Jan 30, 2024

Deploy Preview

What does this PR do?

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@taysea taysea requested a review from oliverHPE January 30, 2024 23:52
Copy link
Collaborator

@oliverHPE oliverHPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have slightly edited the text regarding the icon placement to make it a little more clear.

aries-site/src/pages/components/search.mdx Outdated Show resolved Hide resolved
@taysea taysea merged commit f591de5 into SearchHPE-patch-1 Feb 1, 2024
1 check failed
@taysea taysea deleted the search-taylor-suggestions branch February 1, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants