Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filter layer side drawer guidance #3637

Merged
merged 12 commits into from
Feb 14, 2024
Merged

Conversation

britt6612
Copy link
Collaborator

@britt6612 britt6612 commented Jan 12, 2024

Deploy Preview

What does this PR do?

This PR adds a section about filtering in a side drawer and guidance on how that should be displayed

This also cleans up the code example we had for Configuration Form currently it shows this. This is not only empty but its shows the wrong footer.
Screen Shot 2024-01-12 at 2 54 55 PM

I changed the code to use the grommet Data too be more aligned.

Where should the reviewer start?

side-drawer-layer.mdx

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

site

Any background context you want to provide?

"Filter layer" should be an exception from other actionable modals.
update Design System guidance with rationale.

What are the relevant issues?

part of issue #3629

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

yes

Is this change backwards compatible or is it a breaking change?

@britt6612 britt6612 requested a review from taysea January 12, 2024 21:57
@britt6612 britt6612 self-assigned this Feb 8, 2024
@britt6612 britt6612 requested a review from jcfilben February 12, 2024 17:12
Copy link
Collaborator

@taysea taysea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, filed a suggestion PR into this branch with some wording thoughts:
#3719

@britt6612 britt6612 requested a review from taysea February 13, 2024 16:23
@taysea
Copy link
Collaborator

taysea commented Feb 13, 2024

Screen Shot 2024-02-13 at 11 58 13 AM

Small thing, can we make sure this fills the full width of the example? in mdx maybe we need to add width="100%" to Example?

Also, can you add back DataSummary below Toolbar?

Copy link
Collaborator

@taysea taysea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filter layer still has the "Undo changes" button. Can you update the yarn.lock to get the latest from Grommet?

Brittany Archibeque added 2 commits February 14, 2024 09:06
@britt6612
Copy link
Collaborator Author

@taysea updated now

@taysea taysea self-requested a review February 14, 2024 17:31
Copy link
Collaborator

@taysea taysea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@taysea taysea merged commit ce50928 into master Feb 14, 2024
8 of 9 checks passed
@taysea taysea deleted the add-filter-layer-guidance branch February 14, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants