-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add filter layer side drawer guidance #3637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, filed a suggestion PR into this branch with some wording thoughts:
#3719
Suggestions to filters wording and example
…t/hpe-design-system into add-filter-layer-guidance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filter layer still has the "Undo changes" button. Can you update the yarn.lock
to get the latest from Grommet?
…into add-filter-layer-guidance
@taysea updated now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Deploy Preview
What does this PR do?
This PR adds a section about filtering in a side drawer and guidance on how that should be displayed
This also cleans up the code example we had for
Configuration Form
currently it shows this. This is not only empty but its shows the wrong footer.I changed the code to use the grommet Data too be more aligned.
Where should the reviewer start?
side-drawer-layer.mdx
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
site
Any background context you want to provide?
"Filter layer" should be an exception from other actionable modals.
update Design System guidance with rationale.
What are the relevant issues?
part of issue #3629
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
yes
Is this change backwards compatible or is it a breaking change?