Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change a tag to Anchor from grommet #3615

Merged
merged 1 commit into from
Dec 13, 2023
Merged

change a tag to Anchor from grommet #3615

merged 1 commit into from
Dec 13, 2023

Conversation

britt6612
Copy link
Collaborator

Deploy Preview

What does this PR do?

changes <a> tag to use grommet <Anchor

Where should the reviewer start?

feedback.mdx

What testing has been done on this PR?

local
In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

local to see color changes

Any background context you want to provide?

there was a regular a tag instead of grommet Anchor that has the correct color

What are the relevant issues?

closes #3560

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

no

Is this change backwards compatible or is it a breaking change?

yes

@britt6612 britt6612 requested a review from taysea December 13, 2023 19:55
@britt6612 britt6612 merged commit 191a715 into master Dec 13, 2023
5 of 6 checks passed
@britt6612 britt6612 deleted the fix-anchor-feedback branch December 13, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email links in dark mode don't have a high enough contrast ratio
2 participants