Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add empty state preview #3613

Merged
merged 2 commits into from
Dec 12, 2023
Merged

add empty state preview #3613

merged 2 commits into from
Dec 12, 2023

Conversation

britt6612
Copy link
Collaborator

@britt6612 britt6612 commented Dec 12, 2023

Deploy Preview

What does this PR do?

adds preview for empty states

Where should the reviewer start?

emptystatepreview

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@britt6612 britt6612 requested a review from taysea December 12, 2023 16:38
Copy link
Collaborator

@taysea taysea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments, thanks for getting this started.

@taysea taysea self-requested a review December 12, 2023 17:44
Copy link
Collaborator

@taysea taysea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@taysea taysea merged commit 997cc3b into master Dec 12, 2023
5 of 6 checks passed
@taysea taysea deleted the add-emptystate-preview branch December 12, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants