Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove contradictory heading guidance for card titles #3610

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Dec 7, 2023

Deploy Preview

What does this PR do?

Removes contradictory/outdated guidance from heading page re: card titles. Removing this bullet to allow Card page to serve as source of truth for card guidance.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@taysea taysea requested a review from halocline December 7, 2023 20:00
@taysea taysea requested a review from halocline December 7, 2023 21:06
@taysea taysea merged commit 23d906e into master Dec 7, 2023
5 of 6 checks passed
@taysea taysea deleted the heading-guidance branch December 7, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants