Update pagination.mdx #3603
Closed
Update pagination.mdx #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated documentation around results displayed per page.
taysea
reviewed
Nov 21, 2023
There was a problem hiding this comment.
Copy changes seem reasonable. One thing that might be helpful to add would be a sentence explicitly stating to "always show" pagination controls and why.
@halocline tagging you to look at this and give any feedback on guidance change.
|
Closing this since the guidance has been adjusted more recently by: #3616 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated documentation around results displayed per page.
What does this PR do?
Updates guidance on recommended items returned per page.
Where should the reviewer start?
Check for comprehension and spelling.
Notifications
[Updated]Pagination
['Number of results per page']
['Always show pagination controls instead of hiding them when there is only one page of results.']