Skip to content

Conversation

@mkrouwel
Copy link

also updated ts-interface-checker

@dsagal
Copy link
Member

dsagal commented Apr 20, 2024

Thanks! The fix part looks good although I'll wait to see the corresponding change to ts-interface-checker.

My only complaint is to linting-related changes and package-lock. I have a strong preference for keeping such things separate from functionality PRs. As for whitespace, unless you are proposing changing lint rules to enforce your changes, I'd prefer to skip whitespace tweaks, or else it can become a tug of war between people with different editor settings.

@mkrouwel
Copy link
Author

mkrouwel commented Apr 20, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants