Disable blockmap generation for CI #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently,
electron-builderhas become faulty on GitHub'smacos-13runners. It gets stuck during blockmap generation and seems to hang forever with no further progress.macos-13is an x64 environment, allowingnode-pre-gypto download the correct x64 SQLite3 bindings.macos-14andmacos-15runners are ARM-based and cannot produce correct x64 Grist Desktop builds.electron-builderonly has problems with x64 macOS runners - it works well on ARM macOS runners otherwise.This issues blocks our CI from making valid builds for Intel Macs. Release v0.3.0 is affected.
This PR disables generation of blockmaps for macOS
dmgbuilds. Blockmaps are used forelectron-updaterincremental updates, which we are not using at the moment. Disabling it seems a plausible workaround for now.The way to disable blockmaps is not officially documented, see electron-userland/electron-builder#2900 for details. Furthermore, since this option only exists for
dmgbuilds, we have to dropzipMac builds. It is not a major problem becausedmgis the preferred way to distribute macOS software.Note: A hack similar to #32 is required if we want to build for x64 on ARM runners.