Add support for GenericMessageContent to AmazonBedrockPromptDriver #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
collindutter
force-pushed
the
feature/bedrock-generic-message
branch
3 times, most recently
from
d932ccd to
ed338ce
Compare
collindutter
force-pushed
the
feature/bedrock-generic-message
branch
from
ed338ce to
575482b
Compare
dylanholmes
reviewed
Dec 23, 2024
| class DocumentArtifact(GenericArtifact): | ||
| """Artifact for storing a document. | ||
|
|
||
| Subclassing `GenericArtifact` to avoid printing out `self.value` as `GenericArtifact` does. |
There was a problem hiding this comment.
Feels a little weird to me that this is subclassing is needed for this reason only. Doesn't this mean that everyone using the feature will end up creating this subclass?
There was a problem hiding this comment.
Yeah I don't love it. Let me see if I can provide a more elegant solution to log truncating.
collindutter
force-pushed
the
feature/bedrock-generic-message
branch
2 times, most recently
from
435924d to
cef9ff4
Compare
…d AnthropicPromptDriver
collindutter
force-pushed
the
feature/bedrock-generic-message
branch
from
cef9ff4 to
695f1ac
Compare
dylanholmes
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Added
GenericMessageContentinAnthropicPromptDriverandAmazonBedrockPromptDriver.Issue ticket number and link
Relevant #1475