Skip to content

Remove pdb debugger from output_parser.py#1378

Open
maksimf wants to merge 2 commits intogriffithlab:stagingfrom
maksimf:fix/remove-pdb-debugger
Open

Remove pdb debugger from output_parser.py#1378
maksimf wants to merge 2 commits intogriffithlab:stagingfrom
maksimf:fix/remove-pdb-debugger

Conversation

@maksimf
Copy link
Copy Markdown

@maksimf maksimf commented Mar 17, 2026

Summary

  • Removes pdb.set_trace() debug code left in production in match_wildtype_and_mutant_entry_for_missense()
  • Replaces the bare except: pdb.set_trace() with a proper KeyError that includes the missing position and MT epitope sequence for easier debugging

Problem

Any exception during WT result lookup would freeze execution by dropping into an interactive debugger (pdb), making the tool hang indefinitely in production/CI environments.

susannasiebert and others added 2 commits March 11, 2026 14:19
Replaces bare except/pdb.set_trace() with a proper KeyError that
includes context about the missing wildtype position and epitope sequence.
@susannasiebert susannasiebert changed the base branch from master to staging March 18, 2026 13:01
@susannasiebert
Copy link
Copy Markdown
Contributor

@maksimf Thank you for this pull request.

This breakpoint should really never be hit as it points to a fundamental mismatch between the output files from the chosen predictors and the fasta file generated by pVACseq that is used as input to those predictor calls which shouldn't happen during a normal pVACseq run (from scratch). There are two circumstance where I can imagine hitting this breakpoint/error:

  • pVACseq was rerun with different pre-filtering parameters (e.g. --pass-only, --biotypes, --allow-incomplete-transcripts) on an existing run with existing predictor output files.
  • pVACseq was rerun with a different version on an existing run with existing predictor output files

In both situations pVACseq should be run from scratch.

Could you please provide me some additional information for the circumstance under which you encountered this issue (hanging run in production)?

@maksimf
Copy link
Copy Markdown
Author

maksimf commented Mar 18, 2026

Thank you for the reply, Susanna. To be completely transparent I did not encounter this bug myself, I read through the code and the breakpoint caught my eye, as I thought it was left there unintentionally. If I was wrong then by all means let's close this PR

@susannasiebert
Copy link
Copy Markdown
Contributor

I think changing it to an actual error is nicer so I have no objections to this PR.

Copy link
Copy Markdown
Contributor

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants