Remove pdb debugger from output_parser.py#1378
Remove pdb debugger from output_parser.py#1378maksimf wants to merge 2 commits intogriffithlab:stagingfrom
Conversation
Replaces bare except/pdb.set_trace() with a proper KeyError that includes context about the missing wildtype position and epitope sequence.
|
@maksimf Thank you for this pull request. This breakpoint should really never be hit as it points to a fundamental mismatch between the output files from the chosen predictors and the fasta file generated by pVACseq that is used as input to those predictor calls which shouldn't happen during a normal pVACseq run (from scratch). There are two circumstance where I can imagine hitting this breakpoint/error:
In both situations pVACseq should be run from scratch. Could you please provide me some additional information for the circumstance under which you encountered this issue (hanging run in production)? |
|
Thank you for the reply, Susanna. To be completely transparent I did not encounter this bug myself, I read through the code and the breakpoint caught my eye, as I thought it was left there unintentionally. If I was wrong then by all means let's close this PR |
|
I think changing it to an actual error is nicer so I have no objections to this PR. |
Summary
pdb.set_trace()debug code left in production inmatch_wildtype_and_mutant_entry_for_missense()except: pdb.set_trace()with a properKeyErrorthat includes the missing position and MT epitope sequence for easier debuggingProblem
Any exception during WT result lookup would freeze execution by dropping into an interactive debugger (
pdb), making the tool hang indefinitely in production/CI environments.