Added sortability to Acpt/Rej/Rev columns#1270
Open
ldhtnp wants to merge 1 commit intogriffithlab:stagingfrom
Open
Added sortability to Acpt/Rej/Rev columns#1270ldhtnp wants to merge 1 commit intogriffithlab:stagingfrom
ldhtnp wants to merge 1 commit intogriffithlab:stagingfrom
Conversation
susannasiebert
requested changes
Aug 19, 2025
Contributor
susannasiebert
left a comment
susannasiebert
left a comment
There was a problem hiding this comment.
This overall looks good. A couple of small issues:
- When sorting any of these columns, the selected ones get sorted to the end first. Would be great if they would be sorted to the front so they show up on top after the first click to sort
- The _eval columns show up in the export. They need to be dropped
The biggest issue seems to be that it now re-renders the main table (and all of the secondary panels) after a selection is made because the underlying data changes (even though the data changes are in hidden columns). From reading a bit about this, there doesn't seem to be a straightforward workaround to that but it would be great if you could have a look as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added three hidden columns to store the current state of the Acpt/Rej/Rev columns for each corresponding row. The values in the hidden columns are then used for sorting the Acpt/Rej/Rev columns.
Resolves issue (#1256)