Modification by filter (without formula data migration)

[thangqp]

No description provided.

[thangqp]

I have made a voluntary invalid assignment in my second filter edit line:

As you can see

* The error is not in the right report (it is in "Modification by filter" instead of "Assignment on filters : batteries à moins de 25 kV", which is empty)

* The message "Assignment on filters : batteries à moins de 25 kV" has a strange "unknown" severity. Shouldn't it be an INFO ?

* there is only one error (even if I was assigning this value to several batteries)

At the moment I will keep the actual behaviour as formula, i.e. when exception occurs, do not interrupt next applications and log as warning for exception

https://github.com/gridsuite/network-modification-server/pull/526/files#diff-793232bebcbb224f95ef5d7c306f29898390e54e86f4e68cc792e6724f393a96R310-R318

[Mathieu-Deharbe]

At the moment I will keep the actual behaviour as formula, i.e. when exception occurs, do not interrupt next applications and log as warning for exception

https://github.com/gridsuite/network-modification-server/pull/526/files#diff-793232bebcbb224f95ef5d7c306f29898390e54e86f4e68cc792e6724f393a96R310-R318

Ok fine. But I think a new ticket should be opened about this. It makes the logs very misleading :

It really looks like no equipment has been modified at all but it is only in one of the Assigment by filter. The other worked fine.

[thangqp]

At the moment I will keep the actual behaviour as formula, i.e. when exception occurs, do not interrupt next applications and log as warning for exception
https://github.com/gridsuite/network-modification-server/pull/526/files#diff-793232bebcbb224f95ef5d7c306f29898390e54e86f4e68cc792e6724f393a96R310-R318

Ok fine. But I think a new ticket should be opened about this. It makes the logs very misleading :

It really looks like no equipment has been modified at all but it is only in one of the Assigment by filter. The other worked fine.

In yours case, none of assignments done well, that why the final counter is zero so the parent node is in error severity.

I tested with two modifications, one no error and other with error, I dont see any problem with the counter:

[Mathieu-Deharbe]

In yours case, none of assignments done well, that why the final counter is zero so the parent node is in error severity.

This is what bothers me : the parent is in error severity but the node when the error actually happened has no error. And there is no intuitive way to find where the error happenned : you have to click on the nodes one by one and checks the traces.

[thangqp]

In yours case, none of assignments done well, that why the final counter is zero so the parent node is in error severity.

This is what bothers me : the parent is in error severity but the node when the error actually happened has no error. And there is no intuitive way to find where the error happenned : you have to click on the nodes one by one and checks the traces.

We can set error severity when exception occurs here : https://github.com/gridsuite/network-modification-server/pull/526/files#diff-793232bebcbb224f95ef5d7c306f29898390e54e86f4e68cc792e6724f393a96R317
But I don't know whether it is good solution. In my opinion, error means no next application, we can merge and see Christelle in the next week

[ghazwarhili]

code review => OK

[sonarqubecloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.2% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarCloud