Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add creation cspr modification network #519

Merged
merged 28 commits into from
Oct 11, 2024
Merged

add creation cspr modification network #519

merged 28 commits into from
Oct 11, 2024

Conversation

ghazwarhili
Copy link
Contributor

No description provided.

@ghazwarhili ghazwarhili changed the title first version of creation cspr implement static var compensator modification network Aug 21, 2024
@ghazwarhili ghazwarhili changed the title implement static var compensator modification network add creation cspr modification network Aug 26, 2024
@thangqp thangqp self-requested a review September 11, 2024 10:55
thangqp
thangqp reviewed Sep 11, 2024
View reviewed changes
src/main/java/org/gridsuite/modification/server/dto/StaticVarCompensatorCreationInfos.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/dto/StaticVarCompensatorCreationInfos.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/dto/StaticVarCompensatorCreationInfos.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/dto/StaticVarCompensatorCreationInfos.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/dto/StaticVarCompensatorCreationInfos.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/StaticVarCompensatorCreation.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/StaticVarCompensatorCreation.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/StaticVarCompensatorCreation.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/StaticVarCompensatorCreation.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/StaticVarCompensatorCreation.java Outdated Show resolved Hide resolved
@ghazwarhili ghazwarhili requested a review from thangqp September 11, 2024 21:46
thangqp
thangqp reviewed Sep 17, 2024
View reviewed changes
src/main/java/org/gridsuite/modification/server/dto/StaticVarCompensatorCreationInfos.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java Outdated Show resolved Hide resolved
src/test/java/org/gridsuite/modification/server/utils/ModificationCreation.java Outdated Show resolved Hide resolved
@ghazwarhili ghazwarhili requested a review from thangqp September 17, 2024 13:10
EtienneLt
EtienneLt requested changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@EtienneLt EtienneLt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small things

src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java Outdated Show resolved Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/StaticVarCompensatorCreation.java Outdated Show resolved Hide resolved
@ghazwarhili ghazwarhili requested a review from EtienneLt October 3, 2024 07:37
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ghazwarhili ghazwarhili merged commit b1f1295 into main Oct 11, 2024
3 checks passed
@ghazwarhili ghazwarhili deleted the create-modification-CSPR branch October 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thangqp thangqp thangqp approved these changes

@EtienneLt EtienneLt EtienneLt approved these changes

@etiennehomer etiennehomer etiennehomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ghazwarhili @etiennehomer @EtienneLt @thangqp