refactor tabular modification #412
Conversation
…migration) Signed-off-by: David BRAQUART <[email protected]>
…fication # Conflicts: # src/main/java/org/gridsuite/modification/server/entities/TabularModificationEntity.java
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
Signed-off-by: David BRAQUART <[email protected]>
dbraquart
changed the title
| @NonNull | ||
| private String modificationType; | ||
| private IdentifiableType equipmentType; |
There was a problem hiding this comment.
I think it's not enough. We can have here types like GENERATOR_MODIFICATION, GENERATOR_CREATION or EQUIPMENT_DELETION
There was a problem hiding this comment.
Using ModificationType enum would be more appropriate
There was a problem hiding this comment.
No ModificationType represente all modification types of network
We need only injection modificatio/creation/deletion
There was a problem hiding this comment.
operationType { MODIFICATION, CREATION, DELETION } ?
There was a problem hiding this comment.
You want to use 2 fields : IdentifiableType equipmentType + OperationType operationType ?
There was a problem hiding this comment.
Last decision: we use ModificationType enum. No data migration. Same Front-end.
Signed-off-by: David BRAQUART <[email protected]>
…fication # Conflicts: # src/main/java/org/gridsuite/modification/server/entities/TabularModificationEntity.java # src/main/java/org/gridsuite/modification/server/modifications/TabularModification.java
Signed-off-by: David BRAQUART <[email protected]>
dbraquart
force-pushed
the
refactor-tabular-modification
branch
from
b94dc9e to
23ad0d3
Compare
|
No description provided.