Optimize SQL queries when getting tabular modification of generators #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fication Signed-off-by: Florent MILLOT <[email protected]>
etiennehomer
reviewed
Jan 3, 2024
| @@ -120,6 +120,13 @@ public void testCheckSqlRequestsCount() throws Exception { | |||
| .andReturn(); | |||
| // We check that the request count is not dependent on the number of sub modifications of the tabular modification (the JPA N+1 problem is correctly solved) | |||
| assertSelectCount(3); | |||
| reset(); | |||
|
|
|||
| // Now we get back the 2 tabular modifications | |||
There was a problem hiding this comment.
// We get the modification group
There was a problem hiding this comment.
I just precised this to explain why we have 6 SELECT, but OK I change a bit the comment
etiennehomer
approved these changes
Jan 3, 2024
Signed-off-by: Florent MILLOT <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the n+1 problem when building a node with generators tabular modification.
We just have to call the right method already implemented.