Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checking equipment modifications #397

Merged
merged 8 commits into from
Dec 22, 2023
Merged

Fix checking equipment modifications #397

merged 8 commits into from
Dec 22, 2023

Conversation

flomillot
Copy link
Contributor

Implement the check method when necessary instead of checking data inside the apply method.

Individually check the tabular modifications.

@flomillot
Implement the check method when necessary instead of checking data in…
63152c7 
…side the apply method.

Individually check the tabular modifications.

Signed-off-by: Florent MILLOT <[email protected]>
@antoinebhs antoinebhs self-requested a review December 19, 2023 10:07
@antoinebhs
Copy link
Contributor

Is there a reason why we didn't do it for these cases ?

https://github.com/gridsuite/network-modification-server/blob/c535de666d98c178be5051be8ff6c00a06301870/src/main/java/org/gridsuite/modification/server/modifications/BatteryModification.java#L78C22-L78C22

https://github.com/gridsuite/network-modification-server/blob/c535de666d98c178be5051be8ff6c00a06301870/src/main/java/org/gridsuite/modification/server/modifications/EquipmentDeletion.java#L38C1-L41C1

https://github.com/gridsuite/network-modification-server/blob/c535de666d98c178be5051be8ff6c00a06301870/src/main/java/org/gridsuite/modification/server/modifications/GroovyScript.java#L37C1-L37C1

@flomillot
Copy link
Contributor Author

Is there a reason why we didn't do it for these cases ?

https://github.com/gridsuite/network-modification-server/blob/c535de666d98c178be5051be8ff6c00a06301870/src/main/java/org/gridsuite/modification/server/modifications/BatteryModification.java#L78C22-L78C22

https://github.com/gridsuite/network-modification-server/blob/c535de666d98c178be5051be8ff6c00a06301870/src/main/java/org/gridsuite/modification/server/modifications/EquipmentDeletion.java#L38C1-L41C1

https://github.com/gridsuite/network-modification-server/blob/c535de666d98c178be5051be8ff6c00a06301870/src/main/java/org/gridsuite/modification/server/modifications/GroovyScript.java#L37C1-L37C1

Nope, I just did it quickly and maybe forgot some. I will add them.

@flomillot
Forgot somes
a2bc01b 
Signed-off-by: Florent MILLOT <[email protected]>
@flomillot flomillot requested a review from antoinebhs December 21, 2023 16:14
antoinebhs
antoinebhs approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK

@flomillot
Clean code
01623e1 
Signed-off-by: Florent MILLOT <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
86.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@flomillot flomillot merged commit 3536093 into main Dec 22, 2023
3 checks passed
@flomillot flomillot deleted the fix_check_modifications branch December 22, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klesaulnier klesaulnier klesaulnier approved these changes

@antoinebhs antoinebhs antoinebhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flomillot @antoinebhs @klesaulnier