Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for two windings transformer tabular modifications. #396

Merged
merged 6 commits into from
Dec 22, 2023
Merged

Add support for two windings transformer tabular modifications. #396

merged 6 commits into from
Dec 22, 2023

Conversation

flomillot
Copy link
Contributor

No description provided.

@flomillot flomillot changed the title Add two windings transformer modifications to TabularModificationEntity. Add support for two windings transformer tabular modifications. Dec 15, 2023
@klesaulnier klesaulnier self-requested a review December 19, 2023 09:59
@antoinebhs antoinebhs self-requested a review December 19, 2023 10:07
antoinebhs
antoinebhs approved these changes Dec 20, 2023
View reviewed changes
Copy link
Contributor

@antoinebhs antoinebhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code OK
Tests OK

flomillot and others added 4 commits December 20, 2023 10:23
@flomillot
Merge remote-tracking branch 'origin/main' into add_twt_tabular_modif…
cf3ff57 
…ications

# Conflicts:
#	src/main/java/org/gridsuite/modification/server/entities/TabularModificationEntity.java
#	src/main/java/org/gridsuite/modification/server/modifications/TabularModification.java
@flomillot
Refactor forEach loop variable name to 'modifInfos' in TabularModific…
38cca56 
…ation.java.

Signed-off-by: Florent MILLOT <[email protected]>
@flomillot
Merge branch 'main' into add_twt_tabular_modifications
9f2f13c
@flomillot
Merge branch 'main' into add_twt_tabular_modifications
5b8e280
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@flomillot flomillot merged commit 2882a7a into main Dec 22, 2023
3 checks passed
@flomillot flomillot deleted the add_twt_tabular_modifications branch December 22, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klesaulnier klesaulnier klesaulnier approved these changes

@antoinebhs antoinebhs antoinebhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flomillot @klesaulnier @antoinebhs