Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename activePower and reactivePower for load Modification #394

Merged
merged 2 commits into from
Dec 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ public class LoadModificationInfos extends InjectionModificationInfos {
private AttributeModification<LoadType> loadType;

@Schema(description = "Active power modification")
private AttributeModification<Double> activePower;
private AttributeModification<Double> constantActivePower;

@Schema(description = "Reactive power modification")
private AttributeModification<Double> reactivePower;
private AttributeModification<Double> constantReactivePower;

@Override
public LoadModificationEntity toEntity() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ public void update(@NonNull ModificationInfos modificationInfos) {
private void assignAttributes(LoadModificationInfos loadModificationInfos) {
this.loadTypeValue = loadModificationInfos.getLoadType() != null ? loadModificationInfos.getLoadType().getValue() : null;
this.loadTypeOp = loadModificationInfos.getLoadType() != null ? loadModificationInfos.getLoadType().getOp() : null;
this.activePowerValue = loadModificationInfos.getActivePower() != null ? loadModificationInfos.getActivePower().getValue() : null;
this.activePowerOp = loadModificationInfos.getActivePower() != null ? loadModificationInfos.getActivePower().getOp() : null;
this.reactivePowerValue = loadModificationInfos.getReactivePower() != null ? loadModificationInfos.getReactivePower().getValue() : null;
this.reactivePowerOp = loadModificationInfos.getReactivePower() != null ? loadModificationInfos.getReactivePower().getOp() : null;
this.activePowerValue = loadModificationInfos.getConstantActivePower() != null ? loadModificationInfos.getConstantActivePower().getValue() : null;
this.activePowerOp = loadModificationInfos.getConstantActivePower() != null ? loadModificationInfos.getConstantActivePower().getOp() : null;
this.reactivePowerValue = loadModificationInfos.getConstantReactivePower() != null ? loadModificationInfos.getConstantReactivePower().getValue() : null;
this.reactivePowerOp = loadModificationInfos.getConstantReactivePower() != null ? loadModificationInfos.getConstantReactivePower().getOp() : null;
}

@Override
Expand All @@ -83,7 +83,7 @@ public LoadModificationInfos toModificationInfos() {
.voltageLevelId(AttributeModification.toAttributeModification(getVoltageLevelIdValue(), getVoltageLevelIdOp()))
.busOrBusbarSectionId(AttributeModification.toAttributeModification(getBusOrBusbarSectionIdValue(), getBusOrBusbarSectionIdOp()))
.loadType(AttributeModification.toAttributeModification(getLoadTypeValue(), getLoadTypeOp()))
.activePower(AttributeModification.toAttributeModification(getActivePowerValue(), getActivePowerOp()))
.reactivePower(AttributeModification.toAttributeModification(getReactivePowerValue(), getReactivePowerOp()));
.constantActivePower(AttributeModification.toAttributeModification(getActivePowerValue(), getActivePowerOp()))
.constantReactivePower(AttributeModification.toAttributeModification(getReactivePowerValue(), getReactivePowerOp()));
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ private void modifyLoad(Load load, LoadModificationInfos loadModificationInfos,

ModificationUtils.getInstance().applyElementaryModifications(load::setName, () -> load.getOptionalName().orElse("No value"), loadModificationInfos.getEquipmentName(), subReporter, "Name");
ModificationUtils.getInstance().applyElementaryModifications(load::setLoadType, load::getLoadType, loadModificationInfos.getLoadType(), subReporter, "Type");
ModificationUtils.getInstance().applyElementaryModifications(load::setP0, load::getP0, loadModificationInfos.getActivePower(), subReporter, "Active power");
ModificationUtils.getInstance().applyElementaryModifications(load::setQ0, load::getQ0, loadModificationInfos.getReactivePower(), subReporter, "Reactive power");
ModificationUtils.getInstance().applyElementaryModifications(load::setP0, load::getP0, loadModificationInfos.getConstantActivePower(), subReporter, "Constant active power");
ModificationUtils.getInstance().applyElementaryModifications(load::setQ0, load::getQ0, loadModificationInfos.getConstantReactivePower(), subReporter, "Constant reactive power");

// TODO connectivity modification
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ protected ModificationInfos buildModification() {
.equipmentId("v1load")
.equipmentName(new AttributeModification<>("nameLoad1", OperationType.SET))
.loadType(new AttributeModification<>(LoadType.FICTITIOUS, OperationType.SET))
.activePower(new AttributeModification<>(200.0, OperationType.SET))
.reactivePower(new AttributeModification<>(30.0, OperationType.SET))
.constantActivePower(new AttributeModification<>(200.0, OperationType.SET))
.constantReactivePower(new AttributeModification<>(30.0, OperationType.SET))
.build();
}

Expand All @@ -57,8 +57,8 @@ protected ModificationInfos buildModificationUpdate() {
.stashed(false)
.equipmentName(new AttributeModification<>("nameLoadEdited1", OperationType.SET))
.loadType(new AttributeModification<>(LoadType.AUXILIARY, OperationType.SET))
.activePower(new AttributeModification<>(300.0, OperationType.SET))
.reactivePower(new AttributeModification<>(50.0, OperationType.SET))
.constantActivePower(new AttributeModification<>(300.0, OperationType.SET))
.constantReactivePower(new AttributeModification<>(50.0, OperationType.SET))
.build();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ protected Network createNetwork(UUID networkUuid) {
@Override
protected ModificationInfos buildModification() {
List<ModificationInfos> modifications = List.of(
LoadModificationInfos.builder().equipmentId("v1load").reactivePower(new AttributeModification<>(300., OperationType.SET)).build(),
LoadModificationInfos.builder().equipmentId("v2load").reactivePower(new AttributeModification<>(300., OperationType.SET)).build(),
LoadModificationInfos.builder().equipmentId("v3load").reactivePower(new AttributeModification<>(300., OperationType.SET)).build()
LoadModificationInfos.builder().equipmentId("v1load").constantReactivePower(new AttributeModification<>(300., OperationType.SET)).build(),
LoadModificationInfos.builder().equipmentId("v2load").constantReactivePower(new AttributeModification<>(300., OperationType.SET)).build(),
LoadModificationInfos.builder().equipmentId("v3load").constantReactivePower(new AttributeModification<>(300., OperationType.SET)).build()
);
return TabularModificationInfos.builder()
.modificationType("LOAD_MODIFICATION")
Expand All @@ -49,9 +49,9 @@ protected ModificationInfos buildModification() {
@Override
protected ModificationInfos buildModificationUpdate() {
List<ModificationInfos> modifications = List.of(
LoadModificationInfos.builder().equipmentId("v1load").reactivePower(new AttributeModification<>(500., OperationType.SET)).build(),
LoadModificationInfos.builder().equipmentId("v2load").reactivePower(new AttributeModification<>(500., OperationType.SET)).build(),
LoadModificationInfos.builder().equipmentId("v3load").reactivePower(new AttributeModification<>(500., OperationType.SET)).build()
LoadModificationInfos.builder().equipmentId("v1load").constantReactivePower(new AttributeModification<>(500., OperationType.SET)).build(),
LoadModificationInfos.builder().equipmentId("v2load").constantReactivePower(new AttributeModification<>(500., OperationType.SET)).build(),
LoadModificationInfos.builder().equipmentId("v3load").constantReactivePower(new AttributeModification<>(500., OperationType.SET)).build()
);
return TabularModificationInfos.builder()
.modificationType("LOAD_MODIFICATION")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ public void runBuildTest() throws Exception {
.build().toEntity()
);
entities2.add(LoadModificationInfos.builder().equipmentId("newLoad")
.equipmentName(new AttributeModification<>("newLoadName", OperationType.SET)).activePower(null).build().toEntity());
.equipmentName(new AttributeModification<>("newLoadName", OperationType.SET)).constantActivePower(null).build().toEntity());
entities2.add(GeneratorModificationInfos.builder()
.equipmentId("newGenerator")
.equipmentName(new AttributeModification<>("newGeneratorName", OperationType.SET))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -133,11 +133,11 @@ public static LoadModificationInfos getModificationLoad(String loadId, String vl
}

if (activePower != null) {
builder.activePower(AttributeModification.toAttributeModification(activePower, OperationType.SET));
builder.constantActivePower(AttributeModification.toAttributeModification(activePower, OperationType.SET));
}

if (reactivePower != null) {
builder.reactivePower(AttributeModification.toAttributeModification(reactivePower, OperationType.SET));
builder.constantReactivePower(AttributeModification.toAttributeModification(reactivePower, OperationType.SET));
}

return builder.build();
Expand Down
Loading