Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add voltage level tabular modification. #393

Merged
merged 11 commits into from
Dec 14, 2023
Merged

Add voltage level tabular modification. #393

merged 11 commits into from
Dec 14, 2023

Conversation

AAJELLAL
Copy link
Contributor

No description provided.

FranckLecuyer and others added 5 commits December 4, 2023 10:56
@FranckLecuyer
Voltage init modification logs by equipment type
9a44940 
Signed-off-by: Franck LECUYER <[email protected]>
@FranckLecuyer
Merge branch 'main' into voltage_init_logs_per_equipment_type
ea13c6f
@AAJELLAL
Merge branch 'main' of https://github.com/gridsuite/network-modificat…
c2c76bf 
…ion-server into main

# Conflicts:
#	src/main/java/org/gridsuite/modification/server/modifications/VoltageInitModification.java
#	src/test/resources/reports_voltage_init_modification_ok.json
#	src/test/resources/reports_voltage_init_modification_warnings.json
@AAJELLAL
Add voltage level tabular modification.
fbc2704 
Signed-off-by: AAJELLAL <[email protected]>
@AAJELLAL
Merge branch 'main' of https://github.com/gridsuite/network-modificat…
f053499 
…ion-server into voltage-level-tabular-modification
@AAJELLAL AAJELLAL requested a review from ayolab December 12, 2023 17:23
@dbraquart dbraquart self-requested a review December 13, 2023 10:51
dbraquart
dbraquart requested changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@dbraquart dbraquart left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: just minor remarks
tests: ok

src/main/java/org/gridsuite/modification/server/modifications/TabularModification.java Outdated Show resolved Hide resolved
...fication/server/modifications/tabularmodifications/TabularVoltageLevelModificationsTest.java Show resolved Hide resolved
...fication/server/modifications/tabularmodifications/TabularVoltageLevelModificationsTest.java Show resolved Hide resolved
@AAJELLAL AAJELLAL requested a review from dbraquart December 14, 2023 09:59
dbraquart
dbraquart requested changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: please complete assertAfterNetworkModificationDeletion()
tests: ok

@AAJELLAL
Add more tests.
7312abd 
Signed-off-by: AAJELLAL <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AAJELLAL AAJELLAL requested a review from dbraquart December 14, 2023 14:49
dbraquart
dbraquart approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@dbraquart dbraquart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code: ok
tests: not done with last commit

@AAJELLAL AAJELLAL merged commit 0fb7fd2 into main Dec 14, 2023
3 checks passed
@AAJELLAL AAJELLAL deleted the voltage-level-tabular-modification branch December 14, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbraquart dbraquart dbraquart approved these changes

@ayolab ayolab ayolab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AAJELLAL @dbraquart @ayolab @FranckLecuyer