Share code for modifications exporting filters #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antoinebhs
commented
Dec 8, 2023
•
antoinebhs
commented
- share the code for modifications (scaling, by formula) dealing with filters.
Signed-off-by: BOUHOURS Antoine <[email protected]>
…y handled. Code fixes. Signed-off-by: BOUHOURS Antoine <[email protected]>
FranckLecuyer
requested changes
Dec 11, 2023
src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java
Outdated
Show resolved
Hide resolved
src/main/java/org/gridsuite/modification/server/modifications/ModificationUtils.java
Outdated
Show resolved
Hide resolved
| .flatMap(f -> exportFilters.get(f.getId()) | ||
| .getIdentifiableAttributes() | ||
| .stream()) | ||
| .filter(distinctByKey(IdentifiableAttributes::getId)) |
There was a problem hiding this comment.
No need to log the duplicated ids ?
There was a problem hiding this comment.
@FranckLecuyer @YenguiSeddik I removed this part, it will be handled in a separate PR (there is already a story created) as there are some questions about logging and I found some issues with the logging of scaling features.
I reviewed and treated all your other comments.
src/main/java/org/gridsuite/modification/server/modifications/AbstractScaling.java
Outdated
Show resolved
Hide resolved
Signed-off-by: BOUHOURS Antoine <[email protected]>
|
FranckLecuyer
approved these changes
Dec 13, 2023
YenguiSeddik
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.