fix return impacts when active power control modification #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: achour94 <[email protected]>
| if (participateInfo != null) { | ||
| activePowerControlAdder | ||
| .withParticipate(participateInfo.getValue()); | ||
| reports.add(ModificationUtils.getInstance().buildModificationReport(false, |
There was a problem hiding this comment.
won't this possibly make a report with the same old and new value
Comment on lines
796
to
805
| if (droopInfo != null) { | ||
| activePowerControlAdder | ||
| .withDroop(droop); | ||
| reports.add(ModificationUtils.getInstance().buildModificationReport(Double.NaN, | ||
| droop, | ||
| "Droop")); | ||
| } else { | ||
| activePowerControlAdder | ||
| .withDroop(Double.NaN); | ||
| } |
There was a problem hiding this comment.
isn't this slightly better ?
activePowerControlAdder.withDroop(droop);
if (droopInfo != null) {
reports.add(ModificationUtils.getInstance().buildModificationReport(Double.NaN, droop, "Droop"));
}
Meklo
reviewed
Nov 24, 2023
src/test/java/org/gridsuite/modification/server/modifications/BatteryModificationTest.java
Show resolved
Hide resolved
Signed-off-by: achour94 <[email protected]>
AbdelHedhili
approved these changes
Nov 28, 2023
Meklo
approved these changes
Nov 28, 2023
Signed-off-by: LE SAULNIER Kevin <[email protected]>
Signed-off-by: achour94 <[email protected]>
Signed-off-by: achour94 <[email protected]>
… into fix_battery_modification_update
Signed-off-by: achour94 <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.