fix NullPointerException: delete stashed modification when deleting node

Signed-off-by: Maissa SOUISSI <[email protected]>
gridsuite · Dec 20, 2023 · c4dbfd7 · c4dbfd7
1 parent c535de6
commit c4dbfd7
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/...in/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java b/...in/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java
@@ -307,10 +307,11 @@ public void updateModification(@NonNull UUID modificationUuid, @NonNull Modifica
     public void deleteStashedModificationInGroup(UUID groupUuid, boolean errorOnGroupNotFound) {
         try {
             ModificationGroupEntity groupEntity = getModificationGroup(groupUuid);
-            if (!groupEntity.getModifications().isEmpty()) {
-                List<UUID> stashedModifications = groupEntity.getModifications().stream()
-                    .filter(ModificationEntity::getStashed).map(ModificationEntity::getId).collect(Collectors.toList());
-                deleteModifications(groupUuid, stashedModifications);
+            List<UUID> stashedModificationUuids = groupEntity.getModifications().stream()
+                    .filter(modification -> modification != null && modification.getStashed())
+                    .map(ModificationEntity::getId).collect(Collectors.toList());
+            if (!stashedModificationUuids.isEmpty()) {
+                deleteModifications(groupUuid, stashedModificationUuids);
             }
         } catch (NetworkModificationException e) {
             if (e.getType() == MODIFICATION_GROUP_NOT_FOUND && !errorOnGroupNotFound) {