Move search button in top-bar next to tabs #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move code from commons-ui to GridStudy
Tristan-WorkGH
force-pushed
the
move_topbar
branch
from
a5730b2 to
b604295
Compare
lilian-houdelet
requested changes
Dec 12, 2023
src/components/app-top-bar.js
Outdated
| <Search /> | ||
| </IconButton> | ||
| </Tooltip> | ||
| </Box> |
There was a problem hiding this comment.
Is there any difference between the two search buttons ?
There was a problem hiding this comment.
oups, I forget to remove it!
Yes they don't have the same apparence (mainly one is sqaure retangle and the other is round.
dbraquart
reviewed
Dec 18, 2023
| )} | ||
| {studyUuid && ( | ||
| <Box sx={styles.searchButton}> | ||
| <Tooltip |
There was a problem hiding this comment.
This tooltip was not here before.
Maybe you should ask a PO to confirm ?
There was a problem hiding this comment.
I confirmed with a PO, it's OK.
dbraquart
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also move code from commons-ui to GridStudy
Don't need gridsuite/commons-ui#325 to be tested.