Delete multiple elements #76
Conversation
| @@ -242,6 +242,16 @@ public ResponseEntity<Void> deleteElement(@PathVariable("elementUuid") UUID elem | |||
| return ResponseEntity.ok().build(); | |||
| } | |||
|
|
|||
| @DeleteMapping(value = "/explore/elements/{directoryUuid}/delete-stashed") | |||
| @Operation(summary = "Remove directories/elements") | |||
| @ApiResponses(value = {@ApiResponse(responseCode = "200", description = "Filter creation request delegated to filter server")}) | |||
There was a problem hiding this comment.
That is not the right description
| @ApiResponses(value = {@ApiResponse(responseCode = "200", description = "Filter creation request delegated to filter server")}) | ||
| public ResponseEntity<Void> deleteElements(@RequestParam("ids") List<UUID> elementsUuid, | ||
| @RequestHeader("userId") String userId, | ||
| @PathVariable String directoryUuid) { |
There was a problem hiding this comment.
This variable is not used
There was a problem hiding this comment.
Yes, but we must have an uuid at this position or the gateway will reject our fetch with 403 status
| // FIXME dirty fix to ignore errors and still delete the elements in the directory-server. To delete when handled properly. | ||
| } catch (Exception e) { | ||
| LOGGER.error(e.toString(), e); | ||
| directoryService.deleteDirectoryElements(uuids, userId); |
There was a problem hiding this comment.
Why this method is called in both try and catch !?
There was a problem hiding this comment.
I used the same logic of this PR: #27. we ignore the exception and do the deletion anyway
There was a problem hiding this comment.
consider this suggestion
public void deleteElements(List uuids, String userId) {
try {
uuids.forEach(id -> directoryService.deleteElement(id, userId));
// FIXME dirty fix to ignore errors and still delete the elements in the directory-server. To delete when handled properly.
} catch (Exception e) {
LOGGER.error(e.toString(), e);
} finally {
directoryService.deleteDirectoryElements(uuids, userId);
}
}
|
No description provided.