Skip to content

Commit

Permalink
add description for parameters
Browse files Browse the repository at this point in the history
Signed-off-by: maissa SOUISSI <[email protected]>
  • Loading branch information
souissimai committed Mar 1, 2024
1 parent 91d8711 commit e3f3ea7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -313,9 +313,10 @@ public ResponseEntity<Void> updateParameters(@PathVariable UUID id,
public ResponseEntity<Void> duplicateParameters(@RequestParam("duplicateFrom") UUID parentParameterId,
@RequestParam("name") String parametersName,
@RequestParam(name = QUERY_PARAM_PARAMETERS_TYPE, defaultValue = "") ParametersType parametersType,
@RequestParam("description") String description,
@RequestParam(QUERY_PARAM_PARENT_DIRECTORY_ID) UUID parentDirectoryUuid,
@RequestHeader("userId") String userId) {
exploreService.duplicateParameters(parentParameterId, parametersType, parametersName, parentDirectoryUuid, userId);
exploreService.duplicateParameters(parentParameterId, parametersType, parametersName, description, parentDirectoryUuid, userId);
return ResponseEntity.ok().build();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -259,10 +259,10 @@ public void updateParameters(UUID id, String parameters, ParametersType paramete
updateElementName(id, name, userId);
}

public void duplicateParameters(UUID parentParameterId, ParametersType parametersType, String parametersName, UUID parentDirectoryUuid, String userId) {
public void duplicateParameters(UUID parentParameterId, ParametersType parametersType, String parametersName, String description, UUID parentDirectoryUuid, String userId) {
UUID parametersUuid = parametersService.createParameters(parentParameterId, parametersType);
ElementAttributes elementAttributes = new ElementAttributes(parametersUuid, parametersName, parametersType.name(),
null, userId, 0L, null);
null, userId, 0L, description);
directoryService.createElement(elementAttributes, parentDirectoryUuid, userId);
}

Expand Down
4 changes: 2 additions & 2 deletions src/test/java/org/gridsuite/explore/server/ExploreTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -568,8 +568,8 @@ public void testDuplicateStudy() throws Exception {

@Test
public void testDuplicateParameters() throws Exception {
mockMvc.perform(post("/v1/explore/parameters?duplicateFrom={parentParametersId}&name={parametersName}&type={type}&parentDirectoryUuid={parentDirectoryUuid}",
PARAMETERS_UUID, STUDY1, ParametersType.VOLTAGE_INIT_PARAMETERS, PARENT_DIRECTORY_UUID)
mockMvc.perform(post("/v1/explore/parameters?duplicateFrom={parentParametersId}&name={parametersName}&type={type}&description={description}&parentDirectoryUuid={parentDirectoryUuid}",
PARAMETERS_UUID, STUDY1, ParametersType.VOLTAGE_INIT_PARAMETERS, "description", PARENT_DIRECTORY_UUID)
.header("userId", USER1))
.andExpect(status().isOk());
}
Expand Down

0 comments on commit e3f3ea7

Please sign in to comment.