review

gridsuite · Jan 8, 2025 · 9330534 · 9330534
1 parent a025d13
commit 9330534
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/main/java/org/gridsuite/explore/server/ExploreController.java b/src/main/java/org/gridsuite/explore/server/ExploreController.java
@@ -262,9 +262,8 @@ public ResponseEntity<List<Object>> getCompositeModificationContent(@PathVariabl
     @Operation(summary = "Modify a filter")
     @ApiResponses(value = {@ApiResponse(responseCode = "200", description = "The filter has been successfully modified")})
     public ResponseEntity<Void> changeFilter(@PathVariable UUID id, @RequestBody String filter, @RequestHeader(QUERY_PARAM_USER_ID) String userId,
-                                             @RequestParam("name") String name, @RequestParam("elementUuid") UUID elementUuid,
-                                             @RequestParam("description") String description) {
-        exploreService.updateFilter(id, filter, userId, name, elementUuid, description);
+                                             @RequestParam("name") String name, @RequestParam("description") String description) {
+        exploreService.updateFilter(id, filter, userId, name, description);
         return ResponseEntity.ok().build();
     }
 

diff --git a/src/main/java/org/gridsuite/explore/server/services/ExploreService.java b/src/main/java/org/gridsuite/explore/server/services/ExploreService.java
@@ -215,12 +215,13 @@ public void deleteElementsFromDirectory(List<UUID> uuids, UUID parentDirectoryUu
         }
     }
 
-    public void updateFilter(UUID id, String filter, String userId, String name, UUID elementUuid, String description) {
+    public void updateFilter(UUID id, String filter, String userId, String name, String description) {
         filterService.updateFilter(id, filter, userId);
-        updateElementName(id, name, userId);
+
         ElementAttributes elementAttributes = new ElementAttributes();
         elementAttributes.setDescription(description);
-        directoryService.updateElement(elementUuid, elementAttributes, userId);
+        elementAttributes.setElementName(name);
+        directoryService.updateElement(id, elementAttributes, userId);
     }
 
     public void updateContingencyList(UUID id, String content, String userId, String name, ContingencyListType contingencyListType) {