fix a copy-paste issue on a dead element

gridsuite · Feb 22, 2024 · 652950d · 652950d
1 parent 3b9d35a
commit 652950d
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/main/java/org/gridsuite/explore/server/services/ExploreService.java b/src/main/java/org/gridsuite/explore/server/services/ExploreService.java
@@ -266,9 +266,12 @@ public void createNetworkModifications(List<ElementAttributes> modificationAttri
         // create all corresponding directory elements
         modificationAttributesList.forEach(m -> {
             final UUID newId = newModificationsUuids.get(m.getElementUuid());
-            ElementAttributes elementAttributes = new ElementAttributes(newId, m.getElementName(), MODIFICATION,
-                    null, userId, 0L, m.getDescription());
-            directoryService.createElementWithNewName(elementAttributes, parentDirectoryUuid, userId, true);
+            if (newId != null) {
+                // an Id may be null if a duplication could not succeed (ex: we provide a bad uuid)
+                ElementAttributes elementAttributes = new ElementAttributes(newId, m.getElementName(), MODIFICATION,
+                        null, userId, 0L, m.getDescription());
+                directoryService.createElementWithNewName(elementAttributes, parentDirectoryUuid, userId, true);
+            }
         });
     }
 }