Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gui criteria filter #674

Merged
merged 20 commits into from
Jan 30, 2025
Merged

Improve gui criteria filter #674

merged 20 commits into from
Jan 30, 2025

Conversation

basseche
Copy link
Contributor

No description provided.

@basseche basseche self-assigned this Jan 22, 2025
@basseche basseche changed the title WIP : Improve gui criteria filter Improve gui criteria filter Jan 23, 2025
@Mathieu-Deharbe Mathieu-Deharbe self-requested a review January 28, 2025 10:02
Mathieu-Deharbe
Mathieu-Deharbe reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@Mathieu-Deharbe Mathieu-Deharbe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not important at all but when you click on "is / est" (which cannot be modified) it remains selected in a brightest color. Just like if it was editable.

image

Mathieu-Deharbe
Mathieu-Deharbe reviewed Jan 28, 2025
View reviewed changes
src/translations/fr/filterFr.ts Outdated Show resolved Hide resolved
src/hooks/useSelectAppearance.ts Outdated Show resolved Hide resolved
src/hooks/useSelectAppearance.ts Show resolved Hide resolved
src/hooks/useSelectAppearance.ts Outdated Show resolved Hide resolved
src/hooks/index.ts Show resolved Hide resolved
src/hooks/useSelectAppearance.ts Outdated Show resolved Hide resolved
@thangqp thangqp self-requested a review January 29, 2025 08:24
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@thangqp thangqp self-requested a review January 30, 2025 14:07
@basseche basseche merged commit 5d90904 into main Jan 30, 2025
5 checks passed
@basseche basseche deleted the Improve_Gui_Criteria_Filter branch January 30, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thangqp thangqp thangqp approved these changes

@Mathieu-Deharbe Mathieu-Deharbe Mathieu-Deharbe approved these changes

Assignees

@basseche basseche

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basseche @thangqp @Mathieu-Deharbe