fix(authentication): adapt code for authorization code flow with PKCE #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TheMaskedTurtle
commented
Dec 19, 2023
TheMaskedTurtle
commented
- Correctly renew token based on id_token expiry date and maxExpiresIn of the configuration
- Handle authorization code flow with PKCE on Azure common login (handle wrong issuer)
- Avoid initial silent renew on main page
Signed-off-by: Joris Mancini <[email protected]>
Signed-off-by: Joris Mancini <[email protected]>
Signed-off-by: Joris Mancini <[email protected]>
Signed-off-by: Joris Mancini <[email protected]>
Signed-off-by: Joris Mancini <[email protected]>
Signed-off-by: Joris Mancini <[email protected]>
TheMaskedTurtle
force-pushed
the
jorism/global-auth
branch
from
e2f5de5 to
9951727
Compare
Signed-off-by: Joris Mancini <[email protected]>
This was referenced Dec 20, 2023
Merged
Merged
Merged
TheMaskedTurtle
force-pushed
the
jorism/global-auth
branch
2 times, most recently
from
d1d3433 to
92ba61d
Compare
…pires_in for code flow Signed-off-by: Joris Mancini <[email protected]>
TheMaskedTurtle
force-pushed
the
jorism/global-auth
branch
from
92ba61d to
d48fef2
Compare
jonenst
approved these changes
Jan 31, 2024
Signed-off-by: Joris Mancini <[email protected]>
TheMaskedTurtle
force-pushed
the
jorism/global-auth
branch
from
8a67815 to
ccb2465
Compare
Signed-off-by: Joris Mancini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.