Add about dialog #321
Merged
Add about dialog #321
+667
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sBouzols
reviewed
Nov 30, 2023
sBouzols
reviewed
Nov 30, 2023
sBouzols
reviewed
Nov 30, 2023
sBouzols
reviewed
Nov 30, 2023
sBouzols
reviewed
Nov 30, 2023
sBouzols
reviewed
Nov 30, 2023
sBouzols
reviewed
Nov 30, 2023
sBouzols
reviewed
Nov 30, 2023
flomillot
reviewed
Nov 30, 2023
flomillot
reviewed
Nov 30, 2023
if supported
This was referenced Nov 30, 2023
flomillot
requested changes
Dec 6, 2023
src/components/TopBar/AboutDialog.js
Outdated
| content: "'\\A'", | ||
| whiteSpace: 'pre', | ||
| }, | ||
| '&:first-child': { |
There was a problem hiding this comment.
There's a console warning :
The pseudo class ":first-child" is potentially unsafe when doing server-side rendering. Try changing it to ":first-of-type".
There was a problem hiding this comment.
SSR will never append as we compile the application as static files and are send to the use navigator.
added 2 commits
December 6, 2023 14:29
Signed-off-by: BOUTIER Charly <[email protected]>
Signed-off-by: BOUTIER Charly <[email protected]>
also add more items in demo
Tristan-WorkGH
requested review from
flomillot
and removed request for
souissimai
flomillot
requested changes
Dec 8, 2023
flomillot
approved these changes
Dec 8, 2023
This was referenced Dec 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.