Skip to content

Commit

Permalink
Fixes ellipsis in the about dialog that could hide the module's version.
Browse files Browse the repository at this point in the history
Signed-off-by: BOUTIER Charly <[email protected]>
  • Loading branch information
BOUTIER Charly committed Dec 8, 2023
1 parent cb9a3d6 commit 00dccd8
Showing 1 changed file with 38 additions and 19 deletions.
57 changes: 38 additions & 19 deletions src/components/TopBar/AboutDialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import {
Fade,
Grid,
Stack,
Tooltip,
Typography,
useMediaQuery,
useTheme,
Expand Down Expand Up @@ -377,26 +378,44 @@ const Module = ({ type, name, version, license }) => {
},
}}
>
<Stack
direction="row"
justifyContent="flex-start"
alignItems="baseline"
spacing={1}
>
{ModuleTypesIcons[type] || ModuleTypesIcons['other']}
<Typography display="inline-block" noWrap>
{name || '<?>'}
</Typography>
<Typography
variant="caption"
color={(theme) => theme.palette.text.secondary}
display="inline"
marginLeft={1}
noWrap
<Tooltip title={(name || '<?>') + ' ' + (version || '')}>
<Stack
direction="row"
justifyContent="flex-start"
alignItems="baseline"
spacing={1}
>
{version || null}
</Typography>
</Stack>
<Box
sx={{
flexGrow: 0,
position: 'relative',
top: '4px',
flexShrink: 0,
}}
>
{ModuleTypesIcons[type] || ModuleTypesIcons['other']}
</Box>
<Typography display="inline" noWrap>
{name || '<?>'}
</Typography>
<Box
sx={{
flexGrow: 0,
alignSelf: 'flex-end',
flexShrink: 0,
}}
>
<Typography
variant="caption"
color={(theme) => theme.palette.text.secondary}
display="inline"
noWrap
>
{version || null}
</Typography>
</Box>
</Stack>
</Tooltip>
</Grid>
);
};
Expand Down

0 comments on commit 00dccd8

Please sign in to comment.