Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Add json #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add json #54

wants to merge 1 commit into from

Conversation

@omzouai-visor
Copy link
Contributor

Adds json tags to allow for (un)marshaling into json.

mickeyreiss
mickeyreiss approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@mickeyreiss mickeyreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not 100% sure if the omitempty logic should be the same or different for JSON).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mickeyreiss mickeyreiss mickeyreiss approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@omzouai-visor @mickeyreiss