Listen for change event for bound values#167
Open
DaveWM wants to merge 2 commits intogrevory:masterfrom
Open
Conversation
When you call localStorageService.bind, an event listener is now registered that is fired when the value of the local storage key changes, which updates the value and calls scope.$apply().
DaveWM
changed the title
|
Would appreciate to have that feature also :) |
When local storage for a bound object is updated, it now extends the current object as opposed to overwriting it (this is to preserve unserializable properties, e.g. functions)
Collaborator
Contributor
|
Are changes still required here? I wanted to start work on this, but saw the PR already existes for this functionality. |
|
+1 for this feature. |
|
+1 too :) |
|
This won't actually work because |
|
+1 as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you call localStorageService.bind, an event listener is now
registered that is fired when the value of the local storage key
changes, which updates the value and calls scope.$apply(). fixes #166