Skip to content

Conversation

@bim9262
Copy link
Collaborator

@bim9262 bim9262 commented Jan 7, 2026

@zheltikov
Copy link
Contributor

Tested with Google Calendar, seems to work fine!
2026-01-07_16 26 48
2026-01-07_16 26 48

@bim9262 bim9262 marked this pull request as ready for review January 8, 2026 02:42
@bim9262
Copy link
Collaborator Author

bim9262 commented Jan 8, 2026

@ammgws What are your thoughts on using a version of icalendar tied to the commit of a PR?
I believe we've done it in the past, however I only recall seeing that for other crates managed by other maintainers of this repo.

@ammgws
Copy link
Collaborator

ammgws commented Jan 10, 2026

Yeah... I wouldn't really want to go there unless it is something really critical.

@bim9262
Copy link
Collaborator Author

bim9262 commented Jan 10, 2026

Vendored get_recurrence from hoodie/icalendar#128.
Updated logic so that if there is a recurrence more often than daily, they will be rendered correctly.

@bim9262 bim9262 requested a review from ammgws January 10, 2026 06:29
@bim9262 bim9262 merged commit 2ffea12 into greshake:master Jan 11, 2026
13 checks passed
@bim9262 bim9262 deleted the caldav_expand branch January 11, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

calendar: recurring event are not taken into account

3 participants