Allow a max number of retries after a block fails #2157
+90
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if `max_retries` is not set then no limit is used (same as previous behavior). Fixes greshake#2152
|
Rebased to resolve merge conflict. |
bim9262
force-pushed
the
max_retries
branch
2 times, most recently
from
57e65c3 to
e7b4ee8
Compare
After a block fails, the user can click the retry button to restart the block. This is nicer than having to restart the whole status bar, or sending a signal.
|
I think that with the introduction of a restart button, I'd be ok with setting the default number of retries to some small number (perhaps 5), instead of always allowing unlimited retries. What do you think @ammgws @MaxVerevkin? |
I personally think that at least network failures should be retried indefinitely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
max_retriesis not set then no limit is used (same as previous behavior).Fixes #2152