-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "material-nf" icon set, add icons_format
config option
#1095
Conversation
icons_style
config optionicons_style
config option
icons_style
config optionicons_format
config option
9431ff2
to
3665743
Compare
35b6f82
to
c03d3bc
Compare
afe7867
to
14d598a
Compare
Are the Nerd Fonts mappings different than for the official Google material font? I imagine they would be the same if Nerd Fonts is just an aggregator? |
I checked google's codes and no, they are not the same. That's weird. |
886e7f0
to
ebda3eb
Compare
Should icons_format be able to be overridden on a per-block basis like with themes? |
I'm not sure. I think that disabling |
Yeah it might be the way to go. Now too sure but might be useful if for example you wanted to specify some different icon font for the weather block? If it's trivial to implement then I don't really see any downside to allowing users to override it.
Sure |
Done. |
d01c73d
to
0e93c4e
Compare
Looks OK to me. As a last step I want to check the differences between the patched material font, the official Google one and the Nerd Fonts one.
|
Actually, NerdFonts' README claims that they are using this material icons, not Google's - https://github.com/Templarian/MaterialDesign Google's font has only one charging icon - I haven't found any icons that would "work" in any two of those fonts at the same time yet. |
Google Material Design icons Material Design icons by MaterialDesignIcons.com (annoyingly they don't seem to mention Google anywhere) Nerd Fonts which includes MaterialDesignIcons.com, possibly patched but codepoints the same? "Patched" icons from that gist |
From what I can tell, no, codepoints are different. |
Looks like it. Let's deal with it separately. Thanks for this! |
With
icons_format
Without
icons_format
Font used
Related issues
TODO
Do not applyicons_format
for overridden icons? (Not possible with the current implementation of icons deserialization.)icons_style
toicons_format
material
icon set?