Skip to content

Commit

Permalink
Revert "Reapply "Skip compressed image_copy tests in Compatibility mo…
Browse files Browse the repository at this point in the history
…de. (gpuweb#3140)" (gpuweb#3161)"

This reverts commit 0e06340.

These tests test writeBuffer, copyBufferToTexture, and copyTextureToBuffer
as it says at the top of the file. They should not have been disabled for
textures that don't support copyTextureToBuffer. For those cases they
use rendering compare results.
  • Loading branch information
greggman committed Nov 30, 2023
1 parent 2480dfa commit 3631946
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/webgpu/api/operation/command_buffer/image_copy.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1413,7 +1413,6 @@ bytes in copy works for every format.
.beforeAllSubcases(t => {
const info = kTextureFormatInfo[t.params.format];
t.skipIfTextureFormatNotSupported(t.params.format);
t.skipIfCopyTextureToTextureNotSupportedForFormat(t.params.format);
t.selectDeviceOrSkipTestCase(info.feature);
})
.fn(t => {
Expand Down Expand Up @@ -1511,7 +1510,6 @@ works for every format with 2d and 2d-array textures.
.beforeAllSubcases(t => {
const info = kTextureFormatInfo[t.params.format];
t.skipIfTextureFormatNotSupported(t.params.format);
t.skipIfCopyTextureToTextureNotSupportedForFormat(t.params.format);
t.selectDeviceOrSkipTestCase(info.feature);
})
.fn(t => {
Expand Down Expand Up @@ -1592,7 +1590,6 @@ for all formats. We pass origin and copyExtent as [number, number, number].`
.beforeAllSubcases(t => {
const info = kTextureFormatInfo[t.params.format];
t.skipIfTextureFormatNotSupported(t.params.format);
t.skipIfCopyTextureToTextureNotSupportedForFormat(t.params.format);
t.selectDeviceOrSkipTestCase(info.feature);
})
.fn(t => {
Expand Down Expand Up @@ -1793,7 +1790,6 @@ TODO: Make a variant for depth-stencil formats.
.beforeAllSubcases(t => {
const info = kTextureFormatInfo[t.params.format];
t.skipIfTextureFormatNotSupported(t.params.format);
t.skipIfCopyTextureToTextureNotSupportedForFormat(t.params.format);
t.selectDeviceOrSkipTestCase(info.feature);
})
.fn(t => {
Expand Down

0 comments on commit 3631946

Please sign in to comment.