chores: refactor ecoCode rules ECXXX to creedengo GCIXXX

sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/environment/optimized_api/BluetoothBleCheck.kt

@@ -34,7 +34,7 @@ private const val IMPORT_STR_BLE = "android.bluetooth.le"
 private const val ERROR_MESSAGE = "You are using Bluetooth. Did you take a look at the Bluetooth Low Energy API?"
 private const val GOOD_PRACTICE_MESSAGE = "Using android.bluetooth.le.* is a good practice."
 
-@Rule(key = "EC518")
+@Rule(key = "GCI518")
 class BluetoothBleCheck : AbstractCheck() {
 
     override fun visitImportList(importList: KtImportList, data: KotlinFileContext?) {

sonar-kotlin-checks/src/main/java/org/sonarsource/kotlin/checks/environment/optimized_api/FusedLocationCheck.kt

@@ -30,7 +30,7 @@ private const val GOOD_IMPORT = "com.google.android.gms.location"
 private const val ERROR_MESSAGE =
     "Use com.google.android.gms.location instead of android.location to maximize battery life."
 
-@Rule(key = "EC517")
+@Rule(key = "GCI517")
 class FusedLocationCheck : AbstractCheck() {
 
     override fun visitImportList(importList: KtImportList, data: KotlinFileContext?) {
@@ -45,4 +45,4 @@ class FusedLocationCheck : AbstractCheck() {
             }
         }
     }
-}
+}

sonar-kotlin-plugin/src/main/resources/org/sonar/l10n/kotlin/rules/kotlin/Ecocode_profile.json

@@ -1,7 +1,7 @@
 {
   "name": "ecoCode (Android)",
   "ruleKeys": [
-    "EC518",
-    "EC517"
+    "GCI518",
+    "GCI517"
   ]
 }

sonar-kotlin-plugin/src/main/resources/org/sonar/l10n/kotlin/rules/kotlin/EC517.json → sonar-kotlin-plugin/src/main/resources/org/sonar/l10n/kotlin/rules/kotlin/GCI517.json

@@ -14,5 +14,5 @@
     "eco-design"
   ],
   "defaultSeverity": "Major",
-  "sqKey": "EC517"
-}
+  "sqKey": "GCI517"
+}

sonar-kotlin-plugin/src/main/resources/org/sonar/l10n/kotlin/rules/kotlin/EC518.json → sonar-kotlin-plugin/src/main/resources/org/sonar/l10n/kotlin/rules/kotlin/GCI518.json

@@ -14,5 +14,5 @@
     "eco-design"
   ],
   "defaultSeverity": "Major",
-  "sqKey": "EC518"
-}
+  "sqKey": "GCI518"
+}

sonar-kotlin-plugin/src/test/java/org/sonarsource/kotlin/plugin/KotlinProfileDefinitionTest.kt

@@ -46,6 +46,6 @@ internal class KotlinProfileDefinitionTest {
         assertThat(profile.rules().size).isGreaterThan(MIN_RULE_COUNT)
         assertThat(profile.rules())
             .extracting<String> { obj: BuiltInQualityProfilesDefinition.BuiltInActiveRule -> obj.ruleKey() }
-            .contains("EC518", "EC517")
+            .contains("GCI518", "GCI517")
     }
 }

sonar-kotlin-plugin/src/test/java/org/sonarsource/kotlin/plugin/KotlinRulesDefinitionTest.kt

@@ -36,7 +36,7 @@ internal class KotlinRulesDefinitionTest {
         val repository = repositoryForVersion(Version.create(8, 9))
         Assertions.assertThat(repository!!.name()).isEqualTo("SonarQube")
         Assertions.assertThat(repository.language()).isEqualTo("kotlin")
-        val rule = repository.rule("EC518")!!
+        val rule = repository.rule("GCI518")!!
         Assertions.assertThat(rule.name())
             .isEqualTo("Optimized API: Bluetooth Low-Energy")
         Assertions.assertThat(rule.type()).isEqualTo(RuleType.CODE_SMELL)

sonar-kotlin-plugin/src/test/java/org/sonarsource/kotlin/plugin/KotlinSensorTest.kt

@@ -93,12 +93,12 @@ internal class KotlinSensorTest : AbstractSensorTest() {
      """.trimIndent()
         )
         context.fileSystem().add(inputFile)
-        val checkFactory = checkFactory("EC518")
+        val checkFactory = checkFactory("GCI518")
         sensor(checkFactory).execute(context)
         val issues = context.allIssues()
         assertThat(issues).hasSize(1)
         val issue = issues.iterator().next()
-        assertThat(issue.ruleKey().rule()).isEqualTo("EC518")
+        assertThat(issue.ruleKey().rule()).isEqualTo("GCI518")
         val location = issue.primaryLocation()
         assertThat(location.inputComponent()).isEqualTo(inputFile)
         assertThat(location.message())