Skip to content

Conversation

@fbezagu
Copy link
Contributor

@fbezagu fbezagu commented May 20, 2025

Create new javascript rule Intl.NumberFormat (GCI535)

@fbezagu fbezagu changed the title GCI1433 Intl.NumberFormat #Javascript #RulesSpecifications GCI1433 Intl.NumberFormat #Javascript #RulesSpecifications #Terre May 21, 2025
@fbezagu fbezagu changed the title GCI1433 Intl.NumberFormat #Javascript #RulesSpecifications #Terre GCI1433 Intl.NumberFormat #Javascript #RulesSpecifications #TERRE May 21, 2025
@Nephtys Nephtys force-pushed the rule-numberformat-GCI1433 branch from 01c9849 to bbc02fb Compare May 21, 2025 08:38
@fbezagu fbezagu changed the title GCI1433 Intl.NumberFormat #Javascript #RulesSpecifications #TERRE GCI1433 [TERRE] [2025] Intl.NumberFormat #Javascript #RulesSpecifications May 21, 2025
@MP-Aubay MP-Aubay changed the title GCI1433 [TERRE] [2025] Intl.NumberFormat #Javascript #RulesSpecifications GCI1433 [Team TERRE] [2025] Intl.NumberFormat #Javascript #RulesSpecifications May 21, 2025
@fbezagu fbezagu force-pushed the rule-numberformat-GCI1433 branch 3 times, most recently from 857e90c to 7a76946 Compare May 21, 2025 12:58
@fbezagu fbezagu changed the title GCI1433 [Team TERRE] [2025] Intl.NumberFormat #Javascript #RulesSpecifications GCI535 [Team TERRE] [2025] Intl.NumberFormat #Javascript #RulesSpecifications May 21, 2025
@fbezagu fbezagu force-pushed the rule-numberformat-GCI1433 branch from 7a76946 to 5920f35 Compare May 21, 2025 13:18
Copy link
Member

@utarwyn utarwyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🙏 Can you also update the CHANGELOG?

@Sebi11 Sebi11 force-pushed the rule-numberformat-GCI1433 branch from 5920f35 to e5efcb1 Compare May 27, 2025 07:40
@Sebi11 Sebi11 force-pushed the rule-numberformat-GCI1433 branch from e5efcb1 to 400d272 Compare May 27, 2025 07:46
@Sebi11
Copy link

Sebi11 commented May 27, 2025

Thank you for the contribution 🙏 Can you also update the CHANGELOG?

Changelog added, open to suggestions!

@utarwyn utarwyn merged commit a7eefd3 into green-code-initiative:main May 31, 2025
1 check passed
@dedece35
Copy link
Member

dedece35 commented Jul 6, 2025

Hi @utarwyn,
what do we use a GCI535 id rule instead of the next id rule like GCI95 ?
Do you think we could update this id rule in rules-sepcifications repo and mention it in the two following issues ?

@utarwyn
Copy link
Member

utarwyn commented Jul 6, 2025

@dedece35
what do we use a GCI535 id rule instead of the next id rule like GCI95 ?

Many of the JavaScript/TypeScript rules are named in 52x and 53x, which means that teams during challenges don't have to deal with conflicting identifiers. But I agree that it's questionable to have IDs so far apart in the numbering: a renaming would have to be done at some point. But is it really necessary now?

@dedece35
Copy link
Member

dedece35 commented Jul 8, 2025

@utarwyn for me, final rules with 5xx id are currently mobile rules.
the other kind of rules are non mobile rules.
My point of view is to change this number now because the javascript PR is not merged yet.
Are you ok ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants