Open
Conversation
MP-Aubay
requested changes
May 21, 2025
| @@ -0,0 +1,30 @@ | |||
| package org.greencodeinitiative.creedengo.infra.checks; | |||
There was a problem hiding this comment.
All the Java test file could be deleted, they will be replace by test files (kubernetes yaml, Dockerfile, ...)
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.springframework.data</groupId> |
There was a problem hiding this comment.
This dependencies will no longer be needed here
| @@ -0,0 +1,7 @@ | |||
| sonar.organization=green-code-initiative | |||
| sonar.projectKey=green-code-initiative_ecoCode-linter | |||
| sonar.organization=green-code-initiative | ||
| sonar.projectKey=green-code-initiative_ecoCode-linter | ||
| sonar.projectName=creedengo - Infra language | ||
| sonar.sources=sonar-plugin/src/main/java/ |
There was a problem hiding this comment.
This will evolve when adding real test case
|
|
||
| @Rule(key = "GCI1024") | ||
| public class UseOfProbesCheck implements IacCheck { | ||
| private static final String MESSAGE = "Please configure the probes to ensure the application is healthy and ready."; |
There was a problem hiding this comment.
Rename the message like this "Use kubernetes probes to ensure the application is healthy and ready"
| @@ -0,0 +1,96 @@ | |||
| /* | |||
Author
|
[like] RIGANO Steve reacted to your message:
________________________________
From: MP-Aubay ***@***.***>
Sent: Wednesday, May 21, 2025 2:41:33 PM
To: green-code-initiative/creedengo-infra ***@***.***>
Cc: RIGANO Steve ***@***.***>; Author ***@***.***>
Subject: [EXT] Re: [green-code-initiative/creedengo-infra] initial commit (PR #1)
EXPÉDITEUR EXTERNE : Cet e-mail provient de l'extérieur. Ne cliquez pas sur les liens ou n'ouvrez pas de pièces jointes à moins d’être certain de l'expéditeur.
@MP-Aubay requested changes on this pull request.
________________________________
In src/it/test-projects/creedengo-infra-plugin-test-project/src/main/java/org/greencodeinitiative/creedengo/infra/checks/AvoidFullSQLRequestCheck.java<#1 (comment)>:
@@ -0,0 +1,30 @@
+package org.greencodeinitiative.creedengo.infra.checks;
All the Java test file could be deleted, they will be replace by test files (kubernetes yaml, Dockerfile, ...)
________________________________
In src/it/test-projects/creedengo-infra-plugin-test-project/pom.xml<#1 (comment)>:
+
+ <properties>
+ <java.version>17</java.version>
+ <maven.compiler.source>${java.version}</maven.compiler.source>
+ <maven.compiler.target>${java.version}</maven.compiler.target>
+
+ <sonar.java.binaries>target</sonar.java.binaries>
+
+ <encoding>UTF-8</encoding>
+ <project.build.sourceEncoding>${encoding}</project.build.sourceEncoding>
+ <project.reporting.outputEncoding>${encoding}</project.reporting.outputEncoding>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.springframework.data</groupId>
This dependencies will no longer be needed here
________________________________
In sonar-project.properties<#1 (comment)>:
@@ -0,0 +1,7 @@
+sonar.organization=green-code-initiative
+sonar.projectKey=green-code-initiative_ecoCode-linter
Rename project key to new project
________________________________
In sonar-project.properties<#1 (comment)>:
@@ -0,0 +1,7 @@
+sonar.organization=green-code-initiative
+sonar.projectKey=green-code-initiative_ecoCode-linter
+sonar.projectName=creedengo - Infra language
+sonar.sources=sonar-plugin/src/main/java/
This will evolve when adding real test case
________________________________
In src/main/java/org/greencodeinitiative/creedengo/infra/checks/UseOfProbesCheck.java<#1 (comment)>:
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ */
+package org.greencodeinitiative.creedengo.infra.checks;
+
+import org.sonar.check.Rule;
+import org.sonar.iac.common.api.checks.CheckContext;
+import org.sonar.iac.common.api.checks.IacCheck;
+import org.sonar.iac.common.api.checks.InitContext;
+import org.sonar.iac.helm.tree.api.CommandNode;
+import org.sonar.iac.helm.tree.api.FieldNode;
+import org.sonar.iac.helm.tree.api.Node;
+import org.sonar.iac.kubernetes.visitors.KubernetesCheckContext;
+
***@***.***(key = "GCI1024")
+public class UseOfProbesCheck implements IacCheck {
+ private static final String MESSAGE = "Please configure the probes to ensure the application is healthy and ready.";
Rename the message like this "Use kubernetes probes to ensure the application is healthy and ready"
________________________________
In src/test/java/org/sonar/iac/commons/testing/AbstractCheckListTest.java<#1 (comment)>:
@@ -0,0 +1,96 @@
+/*
Could remove all Java test
—
Reply to this email directly, view it on GitHub<#1 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATGJPUTOGTYZOUFHTDZB56327SGBZAVCNFSM6AAAAAB5SZAFSOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNJXHE3TOMZXHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
Ce message et toutes les pieces jointes (ci-apres le "message") sont etablis a l'attention exclusive de ses destinataires.
Si vous recevez ce message par erreur, merci de le detruire et d'en avertir immediatement l'expediteur par e-mail.
Toute utilisation de ce message non conforme a sa destination, toute diffusion ou toute publication, totale ou partielle, est interdite, sauf autorisation expresse.
Les communications sur Internet n'etant pas securisees, l'expediteur informe qu'il ne peut accepter aucune responsabilite quant au contenu de ce message.
This mail message and attachments (the "message") are solely intended for the addressees.
It is confidential in nature .
If you receive this message in error, please delete it and immediately notify the sender by e-mail.
Any use other than its intended purpose, dissemination or disclosure, either whole or partial, is prohibited except if formal approval is granted.
As communication on the Internet is not secure, the sender does not accept responsibility for the content of this message.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repository initialization
First rule added
TODO : adapt when we'll get an answer from the community : https://community.sonarsource.com/t/need-to-use-sonar-iacs-kubernetes-assertions/141631