feat(console): add envId and orgId to the loggers #11707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-goyal01
added
the
ready_to_test
aditya-goyal01
force-pushed
the
apim-9157-add-envId-and-orgId-in-logger
branch
5 times, most recently
from
221ee55 to
1d306db
Compare
aditya-goyal01
force-pushed
the
apim-9157-add-envId-and-orgId-in-logger
branch
6 times, most recently
from
44b98a3 to
d31bc00
Compare
aditya-goyal01
removed
the
ready_to_test
aditya-goyal01
force-pushed
the
apim-9157-add-envId-and-orgId-in-logger
branch
6 times, most recently
from
f4dfbf5 to
4edb6c6
Compare
phiz71
reviewed
May 20, 2025
helm/values.yaml
Outdated
| @@ -470,9 +470,11 @@ api: | |||
| name: api | |||
| logging: | |||
| debug: false | |||
| contextualLoggingEnabled: false | |||
| contextualLoggingEncoderPattern: "%d{HH:mm:ss.SSS} [%thread] [%X{orgId} %X{envId}] %-5level %logger{36} - %msg%n%n" | |||
There was a problem hiding this comment.
Suggested change
| contextualLoggingEncoderPattern: "%d{HH:mm:ss.SSS} [%thread] [%X{orgId} %X{envId}] %-5level %logger{36} - %msg%n%n" | |
| contextualLoggingEncoderPattern: "%d{HH:mm:ss.SSS} [%thread] [%X{orgId} %X{envId}] %-5level %logger{36} - %msg%n" |
helm/values.yaml
Outdated
| stdout: | ||
| json: false | ||
| encoderPattern: "%d{HH:mm:ss.SSS} [%thread] %-5level %logger{36} - %msg%n" | ||
| encoderPattern: "%d{HH:mm:ss.SSS} [%thread] [%X{orgId} %X{envId}] %-5level %logger{36} - %msg%n" |
There was a problem hiding this comment.
Didn't we say by default it should stay the same as before (i.e. without org and env)?
Sorry I don't remember 🤷🏻 😅
There was a problem hiding this comment.
Yes, we agreed on that. It's updated now. 👍
aditya-goyal01
force-pushed
the
apim-9157-add-envId-and-orgId-in-logger
branch
2 times, most recently
from
fab06a1 to
110559f
Compare
phiz71
approved these changes
May 21, 2025
aditya-goyal01
force-pushed
the
apim-9157-add-envId-and-orgId-in-logger
branch
from
110559f to
dde17ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-9157
Description
Summary
This Pull Request primarily introduces contextual logging functionality within the system. The changes enable the inclusion of organization and environment IDs in log entries, improving traceability and debugging capabilities.
Main Changes
contextualLoggingEnabled: A flag to enable/disable contextual logging.contextualLoggingEncoderPattern: A customizable logging pattern for contextual logs.📚 View the storybook of this branch here