Deflake TestEventHandler #60358
Merged
Deflake TestEventHandler #60358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yong-Han Chen <[email protected]> Signed-off-by: Tim Ross <[email protected]>
rosstimothy
added
no-changelog
hugoShaka
approved these changes
Oct 17, 2025
tigrato
approved these changes
Oct 17, 2025
public-teleport-github-review-bot
bot
removed the request for review
from bernardjkim
|
@rosstimothy See the table below for backport results.
|
This was referenced Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #57144.
This is a buddy PR of #60203. The test was rewritten to be a standard Go test instead of relying on testify/suite. The suite only had a single test and is was determined in a discussion in 60203 that the flake stemmed from suite harness keeping the Auth server alive beyond the subtest of the suite. Now, all cleanup operations happen prior to the test exiting, which prevents writing to temporary test directories beyond the test execution.