Enable noImplictThis rule
#60346
Merged
Enable noImplictThis rule
#60346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzdunek
added
no-changelog
gzdunek
commented
Oct 17, 2025
| return debounced; | ||
| } | ||
|
|
||
| interface MapCacheType { |
There was a problem hiding this comment.
I decided to get rid of memoize because it had many this issues.
It was only used in one place, which was trivial to refactor, and this old-style code was hard to maintain (we already had a few any and TS/ESLint ignores there).
ravicious
reviewed
Oct 17, 2025
|
|
||
| // Subsequent calls return the same value. | ||
| c.update(); | ||
| expect(c.value).toBe(firstReturnValue); |
There was a problem hiding this comment.
This doesn't test the return value of update which runOnce explicitly caches, does it? 😏 We'd need to return the symbol from update instead of storing it in a property. But I guess you also want to test this, so maybe we do both? As in store the symbol on the property but also return it from update.
avatus
approved these changes
Oct 20, 2025
This was referenced Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34192 (funny, it's a 4th search result for "noImplicitThis" in Google)
In #59643 (comment) I had a bug caused by
thisbeing implicitly set toany.To avoid such issues in the future, I enabled
noImplicitThisrule.