[api] Add ListLocks #60344
Draft
[api] Add ListLocks #60344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okraport
force-pushed
the
okraport/paginate-GetLocks
branch
from
014e221 to
8c5a3c2
Compare
This commit moves the lock filter parameters to a filter message in preparation for adding paginated variants of GetLocks. The expected signature is: ``` ListLocks(context.Context, int, string, *types.LockFilter) ([]types.Lock, string, error) RangeLocks(context.Context, string, string, *types.LockFilter) iter.Seq2[types.Lock, error] ``` The filter type is required in `e` to satisfy `LockGetter` hence the new type is added first.
This commits deperecates GetLocks, which should be replaced by a paginated counterpart: ListLocks Towards: gravitational/teleport.e/issues/6759 Changelog: Add paginated API ListLocks, deprecate GetLocks
okraport
force-pushed
the
okraport/paginate-GetLocks
branch
from
8c5a3c2 to
132ac44
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits deperecates GetLocks, which should be replaced by a paginated counterpart:
ListLocks
Towards: gravitational/teleport.e/issues/6759
Changelog: Add paginated API ListLocks, deprecate GetLocks