docs: add access_monitoring_rule schedule documentation #60292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernardjkim
added
the
no-changelog
bernardjkim
temporarily deployed
to
docs-amplify
GitHub Actions
Inactive
github-actions
bot
requested review from
flyinghermit,
mmcallister,
ptgott,
r0mant,
smallinsky and
zmb3
|
Amplify deployment status
|
ptgott
reviewed
Oct 16, 2025
There was a problem hiding this comment.
I think the new H2 might be a little buried, and that we can work the different automatic review sections into the flow of the guide so users don't skip over them. We can make it clearer that the workflow doesn't end with adding traits.
I would:
- Make
Step 3/3something like "Configure automatic reviews" - Turn all the current H2s ending with "automatic reviews" into H3s of the new Step 3
- Add an intro paragraph to Step 3 indicating how automatic reviews make use of the steps the user has already completed, explain what the user has left to do: configure one or more kinds of automatic review.
flyinghermit
approved these changes
Oct 17, 2025
| access_request.spec.resource_labels_intersection["env"].contains("dev") | ||
| desired_state: reviewed | ||
| automatic_review: | ||
| integration: builtin |
There was a problem hiding this comment.
builtin is a name of the default review integration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports: #51682, #55075
This PR updates the automatic review guide to include steps to demonstrate how to setup time-based rules. This also updates the access_monitoring_rules references page to update YAML spec documentation.