remove accidental second ServerInit message in bound keypair join flow #60291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
the
no-changelog
rosstimothy
approved these changes
Oct 15, 2025
marcoandredinis
approved these changes
Oct 16, 2025
public-teleport-github-review-bot
bot
removed the request for review
from zmb3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a second ServerInit message that was accidentally being sent in the bound keypair join server implementation. The ServerInit message is already sent before calling
handleBoundKeypairJoin. The client is currently silently dropping unexpected message types, I've updated the client to return an error in this case. Once approved I'll backport this fix along with the v18 backport of the bound keypair join method (#59843) so that this isn't a problem in the wild.